linux-kernel - Re: [PATCH] target_core_alua: silence GCC warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Feb 2014 14:59:09 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	scsi <linux-scsi@...r.kernel.org>,
	target-devel <target-devel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] target_core_alua: silence GCC warning

On Wed, 2014-02-19 at 11:05 +0100, Paul Bolle wrote:
> On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote:
> > On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> > > -               ret = core_alua_state_nonoptimized(cmd, cdb,
> > > -                                       nonop_delay_msecs, &alua_ascq);
> > > +               core_alua_state_nonoptimized(cmd, cdb, nonop_delay_msecs);
> > 
> > I suggest making core_alua_state_nonoptimized()  return void, too.
> > Currently it always returns zero.
> 
> Good catch. Not sure how I missed that, since I deliberately ignore its
> return value here.
> 
> I'll wait with sending a v2 until after Nicholas or the other target
> developers have given their feedback.
> 
> 

Hi Paul,

The patch is fine with me..  Feel free to post a -v2.

Thanks,

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/