linux-kernel - Re: [PATCH] staging: android: binder: convert commented messages to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEjAsho5dO8VrtUP=jW9QPaSJTiKEdhR5CByk2tJdbxhWM0nwg@mail.gmail.com>
Date:	Thu, 20 Feb 2014 13:12:34 +0900
From:	SeongJae Park <sj38.park@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Sachin Kamat <sachin.kamat@...aro.org>,
	Brian Swetland <swetland@...gle.com>,
	devel@...verdev.osusl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: android: binder: convert commented messages to pr_debug

On Thu, Feb 20, 2014 at 12:24 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Wed, Feb 19, 2014 at 12:49:33PM +0900, SeongJae Park wrote:
>> 2 debugging messages were just commented out for normal case. Let them
>> be activated on debug mode without explicit code modification.
>
> Are you sure this doesn't just always send the messages to the debug log
> all the time now?  Again, I'd just leave it alone...

Yes, I sure it will not unless `DEBUG` defined. I tested it again.

Anyway, I know this patch makes just a little, trivial enhancement and
for somebody, it would not looks like enhancement at all. In these case,
I think maintainer's opinion must be respected.
Also, I agree the code as-is just works and not bad.

Thank you for reviewing and your opinion, Greg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/