>From eaf6a8f28f02220ef2154c76a5345f6aa582e8f7 Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Tue, 11 Feb 2014 19:40:29 +0100 Subject: [PATCH] Android / binder: Fix broken walk in binder_node_release() Fix an issue introduced by commit 008fa749e0fe5b2fffd20b7fe4891bb80d072c6a ("drivers: android: binder: Move the node release code to a separate function") which move and rework some code from binder_deferred_release to the binder_node_release new function. The rework introduced an unfortunate break of the loop that prevent some death notifications to be sent. Signed-off-by: Jeremy Compostella --- drivers/staging/android/binder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index eaec1da..1432d95 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -2904,7 +2904,7 @@ static int binder_node_release(struct binder_node *node, int refs) refs++; if (!ref->death) - goto out; + continue; death++; @@ -2917,7 +2917,6 @@ static int binder_node_release(struct binder_node *node, int refs) BUG(); } -out: binder_debug(BINDER_DEBUG_DEAD_BINDER, "node %d now dead, refs %d, death %d\n", node->debug_id, refs, death); -- 1.7.10.4