linux-kernel - Re: [PATCH 4/8] perf top: Add --percentage option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140220104440.GB11018@krava.brq.redhat.com>
Date:	Thu, 20 Feb 2014 11:44:40 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 4/8] perf top: Add --percentage option

On Mon, Feb 10, 2014 at 11:47:21AM +0900, Namhyung Kim wrote:
> The --percentage option is for controlling overhead percentage
> displayed.  It can only receive either of "relative" or "absolute".
> 
> For more information, please see previous commit same thing done to
> "perf report".
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---

SNIP

>  
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index ed99ec4a309f..a516e0389c5e 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1011,6 +1011,20 @@ parse_percent_limit(const struct option *opt, const char *arg,
>  	return 0;
>  }
>  
> +static int
> +parse_percentage(const struct option *opt __maybe_unused, const char *arg,
> +		 int unset __maybe_unused)
> +{
> +	if (!strcmp(arg, "relative"))
> +		symbol_conf.filter_relative = true;
> +	else if (!strcmp(arg, "absolute"))
> +		symbol_conf.filter_relative = false;
> +	else
> +		return -1;
> +
> +	return 0;
> +}

please make one of parse_percentage functions public and
share it among report/top/diff commands

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/