linux-kernel - Re: [PATCH] sched: keep quiescent cpu out of idle balance loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140220122311.GO27965@twins.programming.kicks-ass.net>
Date:	Thu, 20 Feb 2014 13:23:13 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Lei Wen <leiwen@...vell.com>
Cc:	mingo@...hat.com, preeti.lkml@...il.com, daniel.lezcano@...aro.org,
	viresh.kumar@...aro.org, xjian@...vell.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: keep quiescent cpu out of idle balance loop

On Thu, Feb 20, 2014 at 05:17:04PM +0800, Lei Wen wrote:
> +++ b/kernel/sched/fair.c
> @@ -6883,6 +6883,13 @@ void nohz_balance_enter_idle(int cpu)
>  	if (!cpu_active(cpu))
>  		return;
>  
> +	/*
> +	 * If this cpu is kept outside of root domain, we don't bother
> +	 * to ask it for nohz balance.
> +	 */
> +	if (!cpumask_test_cpu(cpu, this_rq()->rd.span))

 rd->span

Otherwise the compiler gets upset. Fixed it.

> +		return;
> +
>  	if (test_bit(NOHZ_TICK_STOPPED, nohz_flags(cpu)))
>  		return;
>  
> -- 
> 1.8.3.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/