linux-kernel - Re: [PATCH 2/4] Sparc: sparc_cpu_model isn't in asm/system.h any more

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Feb 2014 19:47:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dhowells@...hat.com
Cc:	akpm@...ux-foundation.org, linux-arch@...r.kernel.org,
	arnd@...db.de, linux-kernel@...r.kernel.org,
	sparclinux@...r.kernel.org
Subject: Re: [PATCH 2/4] Sparc: sparc_cpu_model isn't in asm/system.h any
 more

From: David Howells <dhowells@...hat.com>
Date: Wed, 12 Feb 2014 15:45:59 +0000

> sparc_cpu_model isn't in asm/system.h any more, so remove a comment about it.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

That's not all your patch does:

> -	/* extern enum sparc_cpu sparc_cpu_model; */ /* in <asm/system.h> */
> -	if (sparc_cpu_model != sun4m) {
> +	if (sparc_cpu_model != sun4m)
>  		/* We must be on sun4m because we use MMU Bypass ASI. */
>  		return -ENXIO;
> -	}

The basic block is more than one line, therefore the braces are
appropriate.  Please do not remove them, and especially do not
remove them without mentioning them in the commit message.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/