linux-kernel - Re: [PATCH] rename HAS_IOPORT to HAS_IOPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201402201624.19922.arnd@arndb.de>
Date:	Thu, 20 Feb 2014 16:24:19 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	"Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] rename HAS_IOPORT to HAS_IOPORT_MAP

On Thursday 20 February 2014, Uwe Kleine-König wrote:
> If the renamed symbol is defined lib/iomap.c implements ioport_map and
> ioport_unmap and currently (nearly) all platforms define the port
> accessor functions outb/inb and friend unconditionally. So
> HAS_IOPORT_MAP is the better name for this. Consequently NO_IOPORT is
> renamed to NO_IOPORT_MAP.
> 
> The motivation for this change is to reintroduce a symbol HAS_IOPORT
> that signals if outb/int et al are available. I will address that
> at least one merge window later though to keep surprises to a minimum
> and catch new introductions of (HAS|NO)_IOPORT.
> 
> The changes in this commit were done using:
> 
>         $ git grep -l -E '(NO|HAS)_IOPORT' | xargs perl -p -i -e 's/\b((?:CONFIG_)?(?:NO|HAS)_IOPORT)\b/$1_MAP/'
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for taking up that work, I had a similar patch series
some years ago but never followed through with getting it upstream.
If there are no objections, I hope Andrew can queue it up for -mm.
Unfortunately I can't think of a good way to split up the patch
into smaller units that could go through subsystem maintainer
trees, since we want to start reusing the symbol as soon as possible.

Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/