linux-kernel - Re: [PATCH] frv: replace now removed pci_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo4wgVmz5N5nO38LuNBrf7pJ5BkRfy80pY=sJpjneVdnmw@mail.gmail.com>
Date:	Thu, 20 Feb 2014 11:16:32 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	David Howells <dhowells@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yijing Wang <wangyijing@...wei.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] frv: replace now removed pci_bus_b() causing build failure

[+cc linux-pci]

On Thu, Feb 20, 2014 at 10:46 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> In commit 94e6a9b93064b49024b8701d2d81fcb4a821fa09 ("PCI: Remove
> pci_bus_b() and use list_for_each_entry() directly") the function
> pci_bus_b() was removed, but one instance of its usage was missed.
>
> Replace it in the same fashion that the original commit did.
>
> Cc: Yijing Wang <wangyijing@...wei.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Crap, sorry about that.  I added this to my pci/list-for-each-entry
branch for v3.15.

> ---
>
> [Note: commit ID referenced above is from linux-next and will
>  be invalid if the PCI-next content is ever rebased.]
>
>  arch/frv/mb93090-mb00/pci-frv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/frv/mb93090-mb00/pci-frv.c b/arch/frv/mb93090-mb00/pci-frv.c
> index c28121765448..67b1d1685759 100644
> --- a/arch/frv/mb93090-mb00/pci-frv.c
> +++ b/arch/frv/mb93090-mb00/pci-frv.c
> @@ -88,7 +88,7 @@ static void __init pcibios_allocate_bus_resources(struct list_head *bus_list)
>
>         /* Depth-First Search on bus tree */
>         for (ln=bus_list->next; ln != bus_list; ln=ln->next) {
> -               bus = pci_bus_b(ln);
> +               bus = list_entry(ln, struct pci_bus, node);
>                 if ((dev = bus->self)) {
>                         for (idx = PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) {
>                                 r = &dev->resource[idx];
> --
> 1.8.5.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/