linux-kernel - Re: [PATCH] capability: Use current logging styles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140221224810.GA24302@sergelap>
Date:	Fri, 21 Feb 2014 16:48:10 -0600
From:	Serge Hallyn <serge.hallyn@...ntu.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Serge Hallyn <serge.hallyn@...onical.com>,
	linux-security-module <linux-security-module@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] capability: Use current logging styles

Quoting Joe Perches (joe@...ches.com):
> Prefix logging output with "capability: " via pr_fmt.
> Convert printks to pr_<level>.
> Use pr_<level>_once instead of guard flags.
> Coalesce formats.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks.

Acked-by: Serge E. Hallyn <serge.hallyn@...ntu.com>

> ---
>  kernel/capability.c | 29 ++++++++++-------------------
>  1 file changed, 10 insertions(+), 19 deletions(-)
> 
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 34019c5..a8d63df 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -7,6 +7,8 @@
>   * 30 May 2002:	Cleanup, Robert M. Love <rml@...h9.net>
>   */
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  #include <linux/audit.h>
>  #include <linux/capability.h>
>  #include <linux/mm.h>
> @@ -42,15 +44,10 @@ __setup("no_file_caps", file_caps_disable);
>  
>  static void warn_legacy_capability_use(void)
>  {
> -	static int warned;
> -	if (!warned) {
> -		char name[sizeof(current->comm)];
> -
> -		printk(KERN_INFO "warning: `%s' uses 32-bit capabilities"
> -		       " (legacy support in use)\n",
> -		       get_task_comm(name, current));
> -		warned = 1;
> -	}
> +	char name[sizeof(current->comm)];
> +
> +	pr_info_once("warning: `%s' uses 32-bit capabilities (legacy support in use)\n",
> +		     get_task_comm(name, current));
>  }
>  
>  /*
> @@ -71,16 +68,10 @@ static void warn_legacy_capability_use(void)
>  
>  static void warn_deprecated_v2(void)
>  {
> -	static int warned;
> +	char name[sizeof(current->comm)];
>  
> -	if (!warned) {
> -		char name[sizeof(current->comm)];
> -
> -		printk(KERN_INFO "warning: `%s' uses deprecated v2"
> -		       " capabilities in a way that may be insecure.\n",
> -		       get_task_comm(name, current));
> -		warned = 1;
> -	}
> +	pr_info_once("warning: `%s' uses deprecated v2 capabilities in a way that may be insecure\n",
> +		     get_task_comm(name, current));
>  }
>  
>  /*
> @@ -380,7 +371,7 @@ bool has_capability_noaudit(struct task_struct *t, int cap)
>  bool ns_capable(struct user_namespace *ns, int cap)
>  {
>  	if (unlikely(!cap_valid(cap))) {
> -		printk(KERN_CRIT "capable() called with invalid cap=%u\n", cap);
> +		pr_crit("capable() called with invalid cap=%u\n", cap);
>  		BUG();
>  	}
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/