linux-kernel - Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA_UwzK38FpDgv0RKfQG_QZd-OttZBQC60UffbyUGWq8E05PpQ@mail.gmail.com>
Date:	Fri, 21 Feb 2014 17:53:41 -0500
From:	Ray Strode <halfline@...il.com>
To:	Kay Sievers <kay@...y.org>
Cc:	Josh Boyer <jwboyer@...oraproject.org>,
	Hannes Reinecke <hare@...e.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Lennart Poettering <lennart@...ttering.net>,
	Jiri Slaby <jslaby@...e.cz>,
	David Herrmann <dh.herrmann@...il.com>,
	Werner Fink <werner@...e.de>
Subject: Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

Hi,

On Fri, Feb 21, 2014 at 11:01 AM, Kay Sievers <kay@...y.org> wrote:
> Why did the tty0 change to tty1 now? That doesn't look like a "driver
> name" vs. "device name" issue?

I don't know if it's intentional, but the patch does:
+               int index = cs[i]->index;
...
+               driver = cs[i]->device(cs[i], &index);

which will presumably change the index from 0 to 1 because of this code:

static struct tty_driver *vt_console_device(struct console *c, int *index)
{
       *index = c->index ? c->index-1 : fg_console;
       return console_driver;
}

At least that's what it looks like is causing the problem from
browsing through the source a bit.

--Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/