linux-kernel - Re: [PATCH] drbd: Fix future possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140221234253.GD29129@kernel.dk>
Date:	Fri, 21 Feb 2014 15:42:53 -0800
From:	Jens Axboe <axboe@...nel.dk>
To:	Philipp Reisner <philipp.reisner@...bit.com>
Cc:	drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drbd: Fix future possible NULL pointer dereference

On Wed, Feb 19 2014, Philipp Reisner wrote:
> From: Andreas Gruenbacher <agruen@...bit.com>
> 
> Right now every resource has exactly one connection. But we are preparing
> for dynamic connections. I.e. in the future thre can be resources without
> connections.
> 
> However smatch points this out as 'variable dereferenced before check',
> which is correct.
> 
> This issue was introduced in
> drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices

Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/