linux-kernel - Re: [PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140221072001.GF26776@mwanda>
Date:	Fri, 21 Feb 2014 10:20:01 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	黃清隆 <ching2048@...ca.com.tw>
Cc:	jbottomley@...allels.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, fengguang.wu@...el.com,
	Tomas Henzl <thenzl@...hat.com>
Subject: Re: [PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to
 fix command timeout

On Fri, Feb 21, 2014 at 10:56:34AM +0800, 黃清隆 wrote:
> From: Ching <ching2048@...ca.com.tw>
> 
> Rewrite interrupt service routine to fix command timeout on controller
> too heavy loading.
> 
> Singed-off-by: Ching <ching2048@...ca.com.tw>

This email is still line wrapped I'm afraid.  It doesn't apply.

> ---
> 
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c
> b/drivers/scsi/arcmsr/arcmsr_attr.c
> --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-02-07 01:47:24.000000000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_attr.c 2014-01-10 20:28:48.000000000 +0800
> -#define ARCMSR_SCSI_INITIATOR_ID
>          255
> +#define ARCMSR_SCSI_INITIATOR_ID       255

Please do white space changes in a separate change set so that the logic
changes are easier to review.

Use "git citool".  Highlight the lines with white space changes and then
right click and select "Stage lines for commit".  It is a very useful
tool.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/