linux-kernel - Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68ae560f-8cf7-4083-816f-3fa78aed9a87@email.android.com>
Date:	Fri, 21 Feb 2014 04:51:53 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan Beulich <JBeulich@...e.com>, mingo@...e.hu, tglx@...utronix.de
CC:	davem@...emloft.net, dborkman@...hat.com, ffusco@...hat.com,
	tgraf@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] x86/hash: fix build failure with older binutils

How old?

On February 21, 2014 2:32:50 AM PST, Jan Beulich <JBeulich@...e.com> wrote:
>Just like for other ISA extension instruction uses we should check
>whether the assembler actually supports them. The fallback here simply
>is to encode an instruction  with fixed operands (%eax and %ecx).
>
>Signed-off-by: Jan Beulich <jbeulich@...e.com>
>Cc: Francesco Fusco <ffusco@...hat.com>
>Cc: Daniel Borkmann <dborkman@...hat.com>
>Cc: Thomas Graf <tgraf@...hat.com>
>Cc: David S. Miller <davem@...emloft.net>
>---
> arch/x86/Makefile   |    1 +
> arch/x86/lib/hash.c |    4 ++++
> 2 files changed, 5 insertions(+)
>
>--- 3.14-rc3-x86-hash-crc32.orig/arch/x86/Makefile
>+++ 3.14-rc3-x86-hash-crc32/arch/x86/Makefile
>@@ -152,6 +152,7 @@ cfi-sections := $(call as-instr,.cfi_sec
> 
> # does binutils support specific instructions?
> asinstr := $(call as-instr,fxsaveq (%rax),-DCONFIG_AS_FXSAVEQ=1)
>+asinstr += $(call as-instr,crc32l
>%eax$(comma)%eax,-DCONFIG_AS_CRC32=1)
>avx_instr := $(call as-instr,vxorps
>%ymm0$(comma)%ymm1$(comma)%ymm2,-DCONFIG_AS_AVX=1)
>avx2_instr :=$(call as-instr,vpbroadcastb
>%xmm0$(comma)%ymm1,-DCONFIG_AS_AVX2=1)
> 
>--- 3.14-rc3-x86-hash-crc32.orig/arch/x86/lib/hash.c
>+++ 3.14-rc3-x86-hash-crc32/arch/x86/lib/hash.c
>@@ -39,7 +39,11 @@
> 
> static inline u32 crc32_u32(u32 crc, u32 val)
> {
>+#ifdef CONFIG_AS_CRC32
> 	asm ("crc32l %1,%0\n" : "+r" (crc) : "rm" (val));
>+#else
>+	asm (".byte 0xf2, 0x0f, 0x38, 0xf1, 0xc1" : "+a" (crc) : "c" (val));
>+#endif
> 	return crc;
> }
> 

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/