linux-kernel - [PATCH 3.14] power_supply: don't export power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1392988768-16693-1-git-send-email-johannes@sipsolutions.net>
Date:	Fri, 21 Feb 2014 14:19:28 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Jenny TC <jenny.tc@...el.com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	linux-kernel@...r.kernel.org, Anton Vorontsov <anton@...msg.org>,
	luca@...lho.fi, johannes@...solutions.net,
	Johannes Berg <johannes.berg@...el.com>
Subject: [PATCH 3.14] power_supply: don't export power_supply_notifier

From: Johannes Berg <johannes.berg@...el.com>

Since there are registration/unregistration functions and the
invocation is in the core code, there's no need to export the
notifier chain head, make it static instead.

Signed-off-by: Johannes Berg <johannes.berg@...el.com>
---
This should probably go into 3.14 so it's not exported in the release.
---
 drivers/power/power_supply_core.c | 3 +--
 include/linux/power_supply.h      | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c
index 26606641fe44..31a105235c3e 100644
--- a/drivers/power/power_supply_core.c
+++ b/drivers/power/power_supply_core.c
@@ -25,8 +25,7 @@
 struct class *power_supply_class;
 EXPORT_SYMBOL_GPL(power_supply_class);
 
-ATOMIC_NOTIFIER_HEAD(power_supply_notifier);
-EXPORT_SYMBOL_GPL(power_supply_notifier);
+static ATOMIC_NOTIFIER_HEAD(power_supply_notifier);
 
 static struct device_type power_supply_dev_type;
 
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index c9dc4e09854c..80968ee25940 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -240,7 +240,6 @@ struct power_supply_info {
 	int use_for_apm;
 };
 
-extern struct atomic_notifier_head power_supply_notifier;
 extern int power_supply_reg_notifier(struct notifier_block *nb);
 extern void power_supply_unreg_notifier(struct notifier_block *nb);
 extern struct power_supply *power_supply_get_by_name(const char *name);
-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/