linux-kernel - Re: [PATCH] fs/direct-io: remove redundant comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49ob20a4ou.fsf@segfault.boston.devel.redhat.com>
Date:	Fri, 21 Feb 2014 10:03:29 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Gu Zheng <guz.fnst@...fujitsu.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/direct-io: remove redundant comparison

Gu Zheng <guz.fnst@...fujitsu.com> writes:

> The return value of bio_get_nr_vecs() can not bigger than BIO_MAX_PAGES,
> so we can remove redundant the comparison between nr_pages and
> BIO_MAX_PAGES.

Yeah, commit f908ee94 (bio allocation failure due to bio_get_nr_vecs())
added that bounding.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>

>
> Signed-off-by: Gu Zheng <guz.fnst@...fujitsu.com>
> ---
>  fs/direct-io.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index 160a548..6e6bff3 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -664,7 +664,6 @@ static inline int dio_new_bio(struct dio *dio, struct dio_submit *sdio,
>  		goto out;
>  	sector = start_sector << (sdio->blkbits - 9);
>  	nr_pages = min(sdio->pages_in_io, bio_get_nr_vecs(map_bh->b_bdev));
> -	nr_pages = min(nr_pages, BIO_MAX_PAGES);
>  	BUG_ON(nr_pages <= 0);
>  	dio_bio_alloc(dio, sdio, map_bh->b_bdev, sector, nr_pages);
>  	sdio->boundary = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/