lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140221154103.GF31902@saruman.home>
Date:	Fri, 21 Feb 2014 09:41:03 -0600
From:	Felipe Balbi <balbi@...com>
To:	Mark Rutland <mark.rutland@....com>
CC:	Felipe Balbi <balbi@...com>,
	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"michals@...inx.com" <michals@...inx.com>,
	Subbaraya Sundeep Bhatta <sbhatta@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

Hi,

On Fri, Feb 21, 2014 at 12:04:54PM +0000, Mark Rutland wrote:
> > > +Example:
> > > + 		axi-usb2-device@...00000 {
> > > +                        compatible = "xlnx,axi-usb2-device-4.00.a";
> > > +                        interrupt-parent = <0x1>;
> > > +                        interrupts = <0x0 0x39 0x1>;
> > > +                        reg = <0x42e00000 0x10000>;
> > > +                        xlnx,include-dma = <0x1>;
> > > +                };
> > > +
> > 
> > you need to Cc devicetree@...r.kernel.org for this.
> 
> Cheers Filipe; thanks for adding us to Cc :)

sure, but it's "Felipe" ;-)

> > > +	/* Map the registers */
> > > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > +	udc->base_address = devm_ioremap_nocache(&pdev->dev, res->start,
> > > +						 resource_size(res));
> > 
> > use devm_ioremap_resource() instead.
> 
> Also, res might be NULL. You should check that before dereferencing it.

not needed when using devm_ioremap_resource(), see the implementation.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ