linux-kernel - Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140221160151.GA31979@kroah.com>
Date:	Fri, 21 Feb 2014 08:01:51 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Josh Boyer <jwboyer@...oraproject.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Lennart Poettering <lennart@...ttering.net>,
	Kay Sievers <kay@...y.org>, Jiri Slaby <jslaby@...e.cz>,
	David Herrmann <dh.herrmann@...il.com>,
	Werner Fink <werner@...e.de>, Ray Strode <halfline@...il.com>
Subject: Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs
 attribute

On Fri, Feb 21, 2014 at 03:52:44PM +0100, Hannes Reinecke wrote:
> On 02/21/2014 03:48 PM, Josh Boyer wrote:
> > On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> >> 3.13-stable review patch.  If anyone has any objections, please let me know.
> >>
> >> ------------------
> >>
> >> From: Hannes Reinecke <hare@...e.de>
> >>
> >> commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream.
> >>
> >> The 'active' sysfs attribute should refer to the currently active tty
> >> devices the console is running on, not the currently active console.
> >>
> >> The console structure doesn't refer to any device in sysfs, only the tty
> >> the console is running on has.  So we need to print out the tty names in
> >> 'active', not the console names.
> >>
> >> This resolves an issue on s390 platforms in determining the correct
> >> console device to use.
> > 
> > Just to be double sure this is seen, Ray points out that it breaks
> > current plymouth because the heuristic changed.  Hold off on this one?
> > 
> Without this patch systemd won't present a login console for s390.
> I'd prefer fixing plymouth.

We can't break working userspace programs, sorry.  I'll go revert this
patch from the stable kernel's, and from Linus's tree as well, as we
can't break things when 3.14 comes out either.

I'll be glad to take a patch that does not break existing systems...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/