linux-kernel - Re: [tip:x86/asmlinkage] lto: Handle LTO common symbols in module loader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5307A503.1080605@zytor.com>
Date:	Fri, 21 Feb 2014 11:12:03 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	ak@...ux.intel.com, linux-tip-commits@...r.kernel.org,
	Joe Mario <jmario@...hat.com>
CC:	Rusty Russell <rusty@...tcorp.com.au>, mingo@...nel.org,
	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [tip:x86/asmlinkage] lto: Handle LTO common symbols in module
 loader

On 02/20/2014 03:11 PM, Rusty Russell wrote:
> tip-bot for Joe Mario <tipbot@...or.com> writes:
>> Commit-ID:  80375980f1608f43b47abc2671456b23ec68c434
>> Gitweb:     http://git.kernel.org/tip/80375980f1608f43b47abc2671456b23ec68c434
>> Author:     Joe Mario <jmario@...hat.com>
>> AuthorDate: Sat, 8 Feb 2014 09:01:09 +0100
>> Committer:  H. Peter Anvin <hpa@...ux.intel.com>
>> CommitDate: Thu, 13 Feb 2014 20:24:50 -0800
>>
>> lto: Handle LTO common symbols in module loader
>>
>> Here is the workaround I made for having the kernel not reject modules
>> built with -flto.  The clean solution would be to get the compiler to not
>> emit the symbol.  Or if it has to emit the symbol, then emit it as
>> initialized data but put it into a comdat/linkonce section.
> 
> Gah, as I said, fix the damn comment!
> 
>>  		case SHN_COMMON:
>> +			/* Ignore common symbols */
>> +			if (!strncmp(name, "__gnu_lto", 9))
>> +				break;
>> +
>>  			/* We compiled with -fno-common.  These are not
> 
> /* Ignore common symbols */ is so bad, it's not even wrong.
> 

Joe, Andi, could one of you submit an incremental patch to clean up this
comment?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/