linux-kernel - Re: [PATCH] fs, kernel: Support disabling the uselib syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140221121627.19e5d04dbba25984d4be8a15@linux-foundation.org>
Date:	Fri, 21 Feb 2014 12:16:27 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Mike Frysinger <vapier@...too.org>,
	Kyungsik Lee <kyungsik.lee@....com>,
	Jiri Slaby <jslaby@...e.cz>, Eric Paris <eparis@...hat.com>,
	Dwight Engen <dwight.engen@...cle.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs, kernel: Support disabling the uselib syscall

On Fri, 21 Feb 2014 10:11:06 -0800 Josh Triplett <josh@...htriplett.org> wrote:

> uselib hasn't been used since libc5; glibc does not use it.  Support
> turning it off.
> 
> When disabled, also omit the load_elf_library implementation from
> binfmt_elf.c, which only uselib invokes.
> 
> bloat-o-meter:
> add/remove: 0/4 grow/shrink: 0/1 up/down: 0/-785 (-785)
> function                                     old     new   delta
> padzero                                       39      36      -3
> uselib_flags                                  20       -     -20
> sys_uselib                                   168       -    -168
> SyS_uselib                                   168       -    -168
> load_elf_library                             426       -    -426
> 

The patch disables CONFIG_USELIB by default.  This important decision
should be mentioned and justified in the changelog, please.

> +#ifdef CONFIG_USELIB

I wonder if CONFIG_SYS_USELIB would be a better identifier.  We haven't
done anything consistent here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/