linux-kernel - Re: [PATCH 1/2] mmc: host: MMC_SH_MMCIF should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1491186.LfrL8k5P1F@avalon>
Date:	Fri, 21 Feb 2014 21:26:59 +0100
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Amarinder Bindra <a-bindra@...com>
Cc:	Chris Ball <chris@...ntf.net>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mmc: host: MMC_SH_MMCIF should depend on HAS_DMA

Hi Geert,

Thank you for the patches.

On Friday 21 February 2014 20:52:50 Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `sh_mmcif_start_dma_tx':
>     sh_mmcif.c:(.text+0x5a3286): undefined reference to `dma_map_sg'
>     drivers/built-in.o: In function `sh_mmcif_start_dma_rx':
>     sh_mmcif.c:(.text+0x5a33fc): undefined reference to `dma_map_sg'
>     drivers/built-in.o: In function `sh_mmcif_end_cmd':
>     sh_mmcif.c:(.text+0x5a3668): undefined reference to `dma_unmap_sg'
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

For both,

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/mmc/host/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 1384f67abe21..bfe2133d0b9c 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -611,7 +611,7 @@ config MMC_DW_PCI
> 
>  config MMC_SH_MMCIF
>  	tristate "SuperH Internal MMCIF support"
> -	depends on MMC_BLOCK
> +	depends on MMC_BLOCK && HAS_DMA
>  	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
>  	help
>  	  This selects the MMC Host Interface controller (MMCIF).

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/