linux-kernel - Re: [PATCH] x86, kaslr: add missed "static" declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLT=KELXVXYHRyG1GBTCzcxfm5fMdqg5pis93JXQ9GXRw@mail.gmail.com>
Date:	Fri, 21 Feb 2014 12:29:55 -0800
From:	Kees Cook <keescook@...omium.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"x86@...nel.org" <x86@...nel.org>,
	Kees Cook <keescook@...omium.org>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
Subject: Re: [PATCH] x86, kaslr: add missed "static" declarations

On Sun, Feb 9, 2014 at 1:56 PM, Kees Cook <keescook@...omium.org> wrote:
> This silences build warnings about unexported variables and functions.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  arch/x86/boot/compressed/aslr.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c
> index 90a21f430117..4dbf967da50d 100644
> --- a/arch/x86/boot/compressed/aslr.c
> +++ b/arch/x86/boot/compressed/aslr.c
> @@ -111,7 +111,7 @@ struct mem_vector {
>  };
>
>  #define MEM_AVOID_MAX 5
> -struct mem_vector mem_avoid[MEM_AVOID_MAX];
> +static struct mem_vector mem_avoid[MEM_AVOID_MAX];
>
>  static bool mem_contains(struct mem_vector *region, struct mem_vector *item)
>  {
> @@ -180,7 +180,7 @@ static void mem_avoid_init(unsigned long input, unsigned long input_size,
>  }
>
>  /* Does this memory vector overlap a known avoided area? */
> -bool mem_avoid_overlap(struct mem_vector *img)
> +static bool mem_avoid_overlap(struct mem_vector *img)
>  {
>         int i;
>
> @@ -192,8 +192,9 @@ bool mem_avoid_overlap(struct mem_vector *img)
>         return false;
>  }
>
> -unsigned long slots[CONFIG_RANDOMIZE_BASE_MAX_OFFSET / CONFIG_PHYSICAL_ALIGN];
> -unsigned long slot_max = 0;
> +static unsigned long slots[CONFIG_RANDOMIZE_BASE_MAX_OFFSET /
> +                          CONFIG_PHYSICAL_ALIGN];
> +static unsigned long slot_max;
>
>  static void slots_append(unsigned long addr)
>  {
> --
> 1.7.9.5
>
>
> --
> Kees Cook
> Chrome OS Security

Ping on this patch; simple build warning fixes...

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/