linux-kernel - Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140221204907.GA18743@ld-irv-0074>
Date:	Fri, 21 Feb 2014 12:49:07 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-mtd@...ts.infradead.org,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, Richard Weinberger <richard@....at>
Subject: Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA

Hi Geert,

On Fri, Feb 21, 2014 at 09:27:27PM +0100, Laurent Pinchart wrote:
> On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> > If NO_DMA=y:
> > 
> >     drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> >     sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> >     sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
> > 
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> > ---
> >  drivers/mtd/nand/Kconfig |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index 90ff447bf043..e7786913280a 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -458,6 +458,7 @@ config MTD_NAND_MXC
> > 
> >  config MTD_NAND_SH_FLCTL
> >  	tristate "Support for NAND on Renesas SuperH FLCTL"
> > +	depends on HAS_DMA
> >  	depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> >  	help
> >  	  Several Renesas SuperH CPU has FLCTL. This option enables support

It looks like Richard beat you to this. I have a similar patch queued up
in l2-mtd.git:

commit 4c8a074b3abab5a5d77c9a19f2fa5fb9d50f9908
Author: Richard Weinberger <richard@....at>
Date:   Fri Jan 31 13:39:07 2014 +0100

    mtd: nand: flctl: Add dependency on HAS_IOMEM and HAS_DMA

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/