linux-kernel - Re: [PATCH] amd64_edac: Add support for newer F16h models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5307BF6F.8040303@amd.com>
Date:	Fri, 21 Feb 2014 15:04:47 -0600
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
	<x86@...nel.org>, <dougthompson@...ssion.com>,
	<bhelgaas@...gle.com>, <JBeulich@...e.com>,
	<dan.carpenter@...cle.com>, <linux-kernel@...r.kernel.org>,
	<linux-edac@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<Arindam.Nath@....com>
Subject: Re: [PATCH] amd64_edac: Add support for newer F16h models

On 2/21/2014 8:27 AM, Borislav Petkov wrote:
> On Thu, Feb 20, 2014 at 10:28:46AM -0600, Aravind Gopalakrishnan wrote:
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 97fbecd..e91ad27 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -528,6 +528,8 @@
>>   #define PCI_DEVICE_ID_AMD_15H_NB_F5	0x1605
>>   #define PCI_DEVICE_ID_AMD_16H_NB_F3	0x1533
>>   #define PCI_DEVICE_ID_AMD_16H_NB_F4	0x1534
>> +#define PCI_DEVICE_ID_AMD_16H_M30H_NB_F3 0x1583
>> +#define PCI_DEVICE_ID_AMD_16H_M30H_NB_F4 0x1584
> Just put those in arch/x86/include/asm/amd_nb.h as amd64_edac.c includes
> it already and you can avoid the pci_ids.h addition. Unless there are
> plans to use F{3,4} in other places too...
>

F{3,4} are used by hwmon/k10temp.c and hwmon/fam15h_power.c and they 
will need definitions to be places here in pci_ids.h
But I'm not sure if the hwmon drivers need to carry support for this 
model yet (will verify that)

If not, I'll remove them and resend.

Thanks,
-Aravind.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/