linux-kernel - Re: [PATCH net-next 28/35] qlcnic: Use pci_enable_msix_range() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393029870.15717.71.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 22 Feb 2014 00:44:30 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Himanshu Madhani <himanshu.madhani@...gic.com>,
	Rajesh Borundia <rajesh.borundia@...gic.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	linux-driver@...gic.com, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next 28/35] qlcnic: Use pci_enable_msix_range()
 instead of pci_enable_msix()

On Tue, 2014-02-18 at 11:11 +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() and pci_enable_msix_range()
> interfaces.
> 
> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> Cc: Himanshu Madhani <himanshu.madhani@...gic.com>
> Cc: Rajesh Borundia <rajesh.borundia@...gic.com>
> Cc: Shahed Shaikh <shahed.shaikh@...gic.com>
> Cc: linux-driver@...gic.com
> Cc: netdev@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> index 0c077cf..e07fd94 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> @@ -701,13 +701,17 @@ enable_msix:
>  		for (vector = 0; vector < num_msix; vector++)
>  			adapter->msix_entries[vector].entry = vector;
>  
> -		err = pci_enable_msix(pdev, adapter->msix_entries, num_msix);
> -		if (err == 0) {
> +		err = pci_enable_msix_range(pdev,
> +					    adapter->msix_entries, 1, num_msix);
> +
> +		if (err == num_msix) {
>  			adapter->flags |= QLCNIC_MSIX_ENABLED;
>  			adapter->ahw->num_msix = num_msix;
>  			dev_info(&pdev->dev, "using msi-x interrupts\n");
>  			return 0;
>  		} else if (err > 0) {
> +			pci_disable_msix(pdev);
> +
>  			dev_info(&pdev->dev,
>  				 "Unable to allocate %d MSI-X vectors, Available vectors %d\n",
>  				 num_msix, err);

Well this log message is nonsense - we have no idea how many vectors are
available any more.

You should remove this and the retry loop that is no longer needed.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)