linux-kernel - Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA_UwzLkcQSGUUNA_stAcmD-6DFVTZLvE6AoUzvO5iq0ALSSOQ@mail.gmail.com>
Date:	Sat, 22 Feb 2014 19:23:42 -0500
From:	Ray Strode <halfline@...il.com>
To:	David Herrmann <dh.herrmann@...il.com>
Cc:	Hannes Reinecke <hare@...e.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Josh Boyer <jwboyer@...oraproject.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Lennart Poettering <lennart@...ttering.net>,
	Kay Sievers <kay@...y.org>, Jiri Slaby <jslaby@...e.cz>,
	Werner Fink <werner@...e.de>
Subject: Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

Hi,

(resending because my phone tried to send the reply as html mail and
it got rejected)

On Sat, Feb 22, 2014 at 9:27 AM, David Herrmann <dh.herrmann@...il.com> wrote:
> > How about this:
>
> +               driver = cs[i]->device(cs[i], &index);
> +                /* special case for tty0 which must not be resolved */
> +               if (driver && (index > 0 || cs[i]->major != TTY_MAJOR)) {
> +                       count += tty_line_name(driver, index, buf + count);
> +                       count += sprintf(buf + count, "%c", i ? ' ':'\n');
> +               } else
> +                       count += sprintf(buf + count, "%s%d%c",
> +                                        name, index, i ? ' ':'\n');
Assuming I'm reading the code correctly, I don't think that will work.
 Index will be rewritten from 0 to fg_console (which I suppose is
going to be 1) after the device vfunc is called.

--Ray
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/