linux-kernel - [TRIVIAL][PATCH] x86/ioapic: Using printk in func print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201402241342361562172@gmail.com>
Date:	Mon, 24 Feb 2014 13:42:41 +0800
From:	majianpeng <majianpeng@...il.com>
To:	joro <joro@...tes.org>, tglx <tglx@...utronix.de>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [TRIVIAL][PATCH] x86/ioapic: Using printk  in func print_entries avoiding print incomplete infos

Commit(afcc8a40a090f): Introduce x86_io_apic_ops.print_entries for
debugging. Using kernel parameter apci=debug/verbose, kernel print
the incomplete infomation if we don't enable CONFIG_DYNAMIC_DEBUG.
So using printk to replace.

Signed-off-by: Jianpeng Ma <majianpeng@...il.com>
---
 arch/x86/kernel/apic/io_apic.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 6ad4658..26996fc 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1480,14 +1480,14 @@ void native_io_apic_print_entries(unsigned int apic, unsigned int nr_entries)
 {
 	int i;
 
-	pr_debug(" NR Dst Mask Trig IRR Pol Stat Dmod Deli Vect:\n");
+	printk(KERN_DEBUG" NR Dst Mask Trig IRR Pol Stat Dmod Deli Vect:\n");
 
 	for (i = 0; i <= nr_entries; i++) {
 		struct IO_APIC_route_entry entry;
 
 		entry = ioapic_read_entry(apic, i);
 
-		pr_debug(" %02x %02X  ", i, entry.dest);
+		printk(KERN_DEBUG" %02x %02X  ", i, entry.dest);
 		pr_cont("%1d    %1d    %1d   %1d   %1d    "
 			"%1d    %1d    %02X\n",
 			entry.mask,
@@ -1506,7 +1506,7 @@ void intel_ir_io_apic_print_entries(unsigned int apic,
 {
 	int i;
 
-	pr_debug(" NR Indx Fmt Mask Trig IRR Pol Stat Indx2 Zero Vect:\n");
+	printk(KERN_DEBUG" NR Indx Fmt Mask Trig IRR Pol Stat Indx2 Zero Vect:\n");
 
 	for (i = 0; i <= nr_entries; i++) {
 		struct IR_IO_APIC_route_entry *ir_entry;
@@ -1516,7 +1516,7 @@ void intel_ir_io_apic_print_entries(unsigned int apic,
 
 		ir_entry = (struct IR_IO_APIC_route_entry *)&entry;
 
-		pr_debug(" %02x %04X ", i, ir_entry->index);
+		printk(KERN_DEBUG " %02x %04X ", i, ir_entry->index);
 		pr_cont("%1d   %1d    %1d    %1d   %1d   "
 			"%1d    %1d     %X    %02X\n",
 			ir_entry->format,
-- 
1.7.10.4