linux-kernel - Re: linux-next: build warning after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140224172313.2560c05d9e0b189acf8731bf@canb.auug.org.au>
Date:	Mon, 24 Feb 2014 17:23:13 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>,
	Rashika Kheria <rashika.kheria@...il.com>
Subject: Re: linux-next: build warning after merge of the tip tree

Hi Andrew,

On Sun, 23 Feb 2014 22:12:17 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> Doh, I missed that.  I don't know if it's "allowed" or not, but it's
> clearly the wrong thing to do - the whole point of asmlinkage is to
> export the thing to other compilation units.
> 
> So I suppose this:
> 
> mm/process_vm_access.c:416:1: warning: no previous prototype for `compat_process_vm_rw' [-Wmissing-prototypes]
> 
> should be squashed by giving it a prototype.  Something like

Or maybe it should be static but *not* asmlinkage like process_vm_rw() ?

As far as I can see it is only used in mm/process_vm_access.c.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped