linux-kernel - Re: [PATCH 7/8] perf ui/tui: Add 'F' hotkey to toggle percentage output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8761o5vtkh.fsf@sejong.aot.lge.com>
Date:	Mon, 24 Feb 2014 16:49:34 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 7/8] perf ui/tui: Add 'F' hotkey to toggle percentage output

On Thu, 20 Feb 2014 11:54:02 +0100, Jiri Olsa wrote:
> On Mon, Feb 10, 2014 at 11:47:25AM +0900, Namhyung Kim wrote:
>> Add 'F' hotkey to toggle relative and absolute percentage of filtered
>> entries.
>> 
>> Suggested-by: Jiri Olsa <jolsa@...hat.com>
>> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>> ---
>>  tools/perf/ui/browsers/hists.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
>> index 14ba6d524943..681c484c5c8e 100644
>> --- a/tools/perf/ui/browsers/hists.c
>> +++ b/tools/perf/ui/browsers/hists.c
>> @@ -1447,6 +1447,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
>>  	"C             Collapse all callchains\n"			\
>>  	"d             Zoom into current DSO\n"				\
>>  	"E             Expand all callchains\n"				\
>> +	"F             Toggle percentage of filtered entries\n"		\
>>  
>>  	/* help messages are sorted by lexical order of the hotkey */
>>  	const char report_help[] = HIST_BROWSER_HELP_COMMON
>> @@ -1552,6 +1553,9 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
>>  			if (env->arch)
>>  				tui__header_window(env);
>>  			continue;
>> +		case 'F':
>> +			symbol_conf.filter_relative ^= 1;
>> +			continue;
>>  		case K_F1:
>>  		case 'h':
>>  		case '?':
>> -- 
>> 1.7.11.7
>> 
>
> when in relative mode i get 0 samples count
> also in --stdio:
>
> [jolsa@...va perf]$ ./perf report -s symbol --symbols=system_call,vfs_write --stdio --percentage=relative
> Failed to open /tmp/perf-1063.map, continuing without symbols
> # To display the perf.data header info, please use --header/--header-only options.
> #
> # Samples: 0  of event 'cycles'
> # Event count (approx.): 6046797
> #
> # Overhead           Symbol
> # ........  ...............
> #
>     57.05%  [k] system_call
>     42.95%  [k] vfs_write  

Oops, I found that I missed to increase it when adding hist
entries.. will fix.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/