linux-kernel - Re: [PATCH] Staging: comedi: fix coding style issues in poc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140224102112.GE26722@mwanda>
Date:	Mon, 24 Feb 2014 13:21:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	David Roddick <dgroddick@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	abbotti@....co.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style issues in poc.c

You have not understood what Joe said.

On Mon, Feb 24, 2014 at 08:48:47PM +1100, David Roddick wrote:
> Removed unnecessary spaces after function pointer names and corrected multi-line wrap alignment
> 

This should be line wrapped at 72 characters (same rule as email).  In
other words it should take two lines like this:

Removed unnecessary spaces after function pointer names and corrected
multi-line wrap alignment.

> Signed-off-by: David Roddick <dgroddick@...il.com>
> ---
>  drivers/staging/comedi/drivers/poc.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c
> index 2ae4ee1..514ccd8 100644
> --- a/drivers/staging/comedi/drivers/poc.c
> +++ b/drivers/staging/comedi/drivers/poc.c
> @@ -36,16 +36,16 @@ Configuration options:
>  struct boarddef_struct {
>  	const char *name;
>  	unsigned int iosize;
> -	int (*setup) (struct comedi_device *);
> +	int (*setup)(struct comedi_device *);
>  	int type;
>  	int n_chan;
>  	int n_bits;
> -	int (*winsn) (struct comedi_device *, struct comedi_subdevice *,
> -		      struct comedi_insn *, unsigned int *);
> -	int (*rinsn) (struct comedi_device *, struct comedi_subdevice *,
> -		      struct comedi_insn *, unsigned int *);
> -	int (*insnbits) (struct comedi_device *, struct comedi_subdevice *,
> -			 struct comedi_insn *, unsigned int *);
> +	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
> +		struct comedi_insn *, unsigned int *);

This is wrong.  It should be exactly like Joe said:

	int (*winsn)(struct comedi_device *, struct comedi_subdevice *,
		     struct comedi_insn *, unsigned int *);

[tab][tab][space][space][space][space][space]struct comedi_insn *,

Ideally it would have a variable name here, but since that wasn't there
in the original, we would accept the patch without it.  All the data
types are pretty clear what they are already, the only thing which is
not clear is what the last parameter does.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/