linux-kernel - RE: sisusb: Use static const, fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6C9771@AcuExch.aculab.com>
Date:	Mon, 24 Feb 2014 10:26:53 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Joe Perches' <joe@...ches.com>,
	Thomas Winischhofer <thomas@...ischhofer.net>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: RE: sisusb: Use static const, fix typo

From: Joe Perches
> Reduce text a bit by using static const.

If you want to save a few bytes remove the pointers.
(and the fixed RAM text to get below 7 chars).
eg:

> -	const char *ramtypetext2[] = {	"SDR SDRAM", "SDR SGRAM",
> -					"DDR SDRAM", "DDR SGRAM" };

	static const char ramtypetext2[8][] = {
		"SDR SD", "SDR SG", "DDR SD", "DDR SG"

...
> -	dev_info(&sisusb->sisusb_dev->dev, "%dMB %s %s, bus width %d\n", (sisusb->vramsize >> 20),
> ramtypetext1,
> -			ramtypetext2[ramtype], bw);

	dev_info(&sisusb->sisusb_dev->dev, "%dMB %s %sRAM, bus width %d\n",
		 sisusb->vramsize >> 20, ramtypetext1, ramtypetext2[ramtype],
		 bw);

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/