| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACRpkdaobDYg6KAEetu5dpp+6ksu7ptvQ+D9rn7jRH0H+bFFQA@mail.gmail.com> Date: Mon, 24 Feb 2014 13:08:46 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: David Daney <ddaney.cavm@...il.com> Cc: Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Alexandre Courbot <gnurou@...il.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, David Daney <david.daney@...ium.com> Subject: Re: [PATCH] of/gpio: Define OF_GPIO_OPEN_DRAIN flag for Open Drain outputs. On Mon, Feb 10, 2014 at 11:05 PM, David Daney <ddaney.cavm@...il.com> wrote: > From: David Daney <david.daney@...ium.com> > > When we have a GPIO pin connected to an open-drain network, we want a > standard way of specifying this in the device tree. So we choose bit > 1 of the flag field to indicate open drain. This is a good idea. But the patch is missing two things: - Add open source as well, as indicated. - Add this definition to include/dt-bindings/gpio/gpio.h - Add this *and* the missing active low property to the binding documentation in: Documentation/devicetree/bindings/gpio/gpio.txt (pls help with this!) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists