linux-kernel - Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140224180554.GE32621@sonymobile.com>
Date:	Mon, 24 Feb 2014 10:05:54 -0800
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Josh Cartwright <joshc@...eaurora.org>
CC:	"Ivan T. Ivanov" <iivanov@...sol.com>,
	Kumar Gala <galak@...eaurora.org>,
	Mark Rutland <mark.rutland@....com>,
	devicetree <devicetree@...r.kernel.org>,
	Pawel Moll <pawel.moll@....com>,
	Wolfram Sang <wsa@...-dreams.de>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Rob Landley <rob@...dley.net>,
	Andy Gross <agross@...eaurora.org>,
	Grant Likely <grant.likely@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C
 controller

On Mon 24 Feb 09:40 PST 2014, Josh Cartwright wrote:

> On Mon, Feb 24, 2014 at 12:33:10PM +0200, Ivan T. Ivanov wrote:
> > On Fri, 2014-02-21 at 09:35 -0600, Kumar Gala wrote: 
> > > On Feb 20, 2014, at 6:38 PM, Bjorn Andersson <bjorn.andersson@...ymobile.com> wrote:
> > > 
> > > > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs.
> > > > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path
> > > > engine with input/output FIFOs and an embedded i2c mini-core. The driver
> > > > supports FIFO mode (for low bandwidth applications) and block mode (interrupt
> > > > generated for each block-size data transfer).
> > > > 
> > > > Cc: Andy Gross <agross@...eaurora.org>
> > > > Cc: Stephen Boyd <sboyd@...eaurora.org>
> > > > Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com>
> > > > ---
> > > > +config I2C_QUP
> > > > +	tristate "Qualcomm QUP based I2C controller"
> > > > +	depends on ARCH_MSM
> > > 
> > > ARCH_QCOM
> > 
> > There is no such symbol, still.
> 
> For what it's worth, the rename/split is in linux-next, and will land in
> 3.15 (as part of arm-soc cleanups).
> 
> Is the (short-term) problem of the lack of the symbol a problem?  Worse
> case, this driver lands before the ARCH_QCOM rename lands, and the
> driver is just not selectable.  Only when both are in place can the
> driver be selected.

As it's best case that this driver lands at the same time as that cleanup I do
agree. I'll "rebase" this ontop of Kumar's series for the next revision.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/