linux-kernel - [PATCH 0/1] hfsplus: fix longname handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1393269828.27792.5.camel@ultrabook>
Date:	Mon, 24 Feb 2014 21:23:48 +0200
From:	Sougata Santra <sougata@...era.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Joe Perches <joe@...ches.com>,
	Vyacheslav Dubeyko <slava@...eyko.com>,
	Christoph Hellwig <hch@....de>,
	Sougata Santra <sougata@...era.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH 0/1] hfsplus: fix longname handling

Hi,

Longname is not correctly handled by hfsplus driver. If an attempt to
create a longname(>255) file/directory is made, it succeeds by creating
a file/directory with HFSPLUS_MAX_STRLEN and incorrect catalog key.
Thus leaving the volume in an inconsistent state. This patch fixes
this issue.

Although lookup is always called first to create a negative entry, so just
doing a check in lookup would probably fix this issue. I choose to propagate
error to other iops as well.

Please NOTE: I have factored out hfsplus_cat_build_key_with_cnid from 
hfsplus_cat_build_key, to avoid unncessary branching.

Thanks a lot.

TEST:
------
dir="TEST_DIR"
cdir=`pwd`
name255="_123456789_123456789_123456789_123456789_123456789_123456789\
_123456789_123456789_123456789_123456789_123456789_123456789_123456789\
_123456789_123456789_123456789_123456789_123456789_123456789_123456789\
_123456789_123456789_123456789_123456789_123456789_1234"
name256="${name255}5"

mkdir $dir
cd $dir
touch $name255
rm -f $name255
touch $name256
ls -la
cd $cdir
rm -rf $dir


RESULT:
-------
[sougata@...rabook tmp]$ cdir=`pwd`
[sougata@...rabook tmp]$ 
name255="_123456789_123456789_123456789_123456789_123456789_123456789\
 > _123456789_123456789_123456789_123456789_123456789_123456789_123456789\
 > _123456789_123456789_123456789_123456789_123456789_123456789_123456789\
 > _123456789_123456789_123456789_123456789_123456789_1234"
[sougata@...rabook tmp]$ name256="${name255}5"
[sougata@...rabook tmp]$
[sougata@...rabook tmp]$ mkdir $dir
[sougata@...rabook tmp]$ cd $dir
[sougata@...rabook TEST_DIR]$ touch $name255
[sougata@...rabook TEST_DIR]$ rm -f $name255
[sougata@...rabook TEST_DIR]$ touch $name256
[sougata@...rabook TEST_DIR]$ ls -la
ls: cannot access 
_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_1234:
No such file or directory
total 0
drwxrwxr-x 1 sougata sougata 3 Feb 20 19:56 .
drwxrwxrwx 1 root    root    6 Feb 20 19:56 ..
-????????? ? ?       ?       ?            ? 
_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789_1234
[sougata@...rabook TEST_DIR]$ cd $cdir
[sougata@...rabook tmp]$ rm -rf $dir
rm: cannot remove ‘TEST_DIR’: Directory not empty


Sougata Santra (1):
  hfsplus: fix longname handling

 fs/hfsplus/catalog.c    | 89 ++++++++++++++++++++++++++++++++++++-------------
 fs/hfsplus/dir.c        | 11 ++++--
 fs/hfsplus/hfsplus_fs.h |  4 ++-
 fs/hfsplus/super.c      |  4 ++-
 4 files changed, 79 insertions(+), 29 deletions(-)

-- 
1.8.5.3



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/