linux-kernel - Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor feature names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <530AC7E3.6050403@zytor.com>
Date:	Sun, 23 Feb 2014 20:17:39 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Josh Triplett <josh@...htriplett.org>
CC:	Borislav Petkov <bp@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Feng Tang <feng.tang@...el.com>,
	Ingo Molnar <mingo@...hat.com>,
	Jacob Shin <jacob.shin@....com>,
	Jan Beulich <JBeulich@...e.com>,
	Jussi Kivilinna <jussi.kivilinna@....fi>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Rob Landley <rob@...dley.net>,
	Seiji Aguchi <seiji.aguchi@....com>,
	Stephane Eranian <eranian@...gle.com>,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor
 feature names

On 02/23/2014 01:55 PM, Josh Triplett wrote:
> 
> Why have the build system waste time building several things that won't
> be used?  It seems like the Makefiles are exactly where we *should* have
> the ifdef machinery, rather than in source.  I'd happily add another
> ifdef in the Makefile rule that builds cpustr.h, to generate a stub
> cpustr.h header, and then remove one more ifdef in the source.
> 

The ifdeffery in the Makefiles really tend to be more complicated than
in the source code.  The amount of code added from v2 to v3 when it
could be handled by *removing* two lines in the Makefile makes it worth it.

If it was enough build stuff to be anywhere near remotely significant it
would be one thing.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/