linux-kernel - Re: [patch 07/26] pci: pcie-designware: Remove irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo4doDT7TC5ACxnizWJFTq+8N1Q3Y8F9_oosTg6w0GQfCA@mail.gmail.com>
Date:	Mon, 24 Feb 2014 16:03:19 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Jingoo Han <jg1.han@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Mohit Kumar <mohit.kumar@...com>,
	pci <linux-pci@...r.kernel.org>
Subject: Re: [patch 07/26] pci: pcie-designware: Remove irq_desc abuse

On Mon, Feb 24, 2014 at 3:06 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Mon, 24 Feb 2014, Bjorn Helgaas wrote:
>> On Sun, Feb 23, 2014 at 4:33 PM, Jingoo Han <jg1.han@...sung.com> wrote:
>> > On Monday, February 24, 2014 6:40 AM, Thomas Gleixner wrote:
>> >>
>> >> There is no reason to care about irq_desc in that context, escpecially
>> >> as irq_data for that interrupt is retrieved as well.
>> >>
>> >> Use the proper accessor for the msi descriptor
>> >>
>> >> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>> >> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
>> >> Cc: Jingoo Han <jg1.han@...sung.com>
>> >> Cc: Mohit Kumar <mohit.kumar@...com>
>> >> Cc: pci <linux-pci@...r.kernel.org>
>> >
>> > Acked-by: Jingoo Han <jg1.han@...sung.com>
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
>>
>> Thomas, I assume you'll merge this along with the rest of your series.
>>  I don't have any pending changes in this area.
>
> I can do, but it does not depend on anything else, so you can pick it
> up as well. Either way is fine.

I never know what to do with these.  I suggested that you pick it up
so the whole series would be together, because I assumed it would make
more sense in the git history to have all these similar changes
grouped together.  But maybe that really doesn't matter.

What's the recommended practice?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/