linux-kernel - Re: [PATCH 2/2] PCI / PM: Resume runtime-suspended devices later during system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Feb 2014 00:33:51 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 2/2] PCI / PM: Resume runtime-suspended devices later during system suspend

On Monday, February 24, 2014 01:58:05 PM Bjorn Helgaas wrote:
> On Sun, Feb 23, 2014 at 4:21 PM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > Runtime-suspended devices are resumed during system suspend by
> > pci_pm_prepare() for two reasons: First, because they may need
> > to be reprogrammed in order to change their wakeup settings and,
> > second, because they may need to be operatonal for their children
> > to be successfully suspended.  That is a problem, though, if there
> > are many runtime-suspended devices that need to be resumed this
> > way during system suspend, because the .prepare() PM callbacks of
> > devices are executed sequentially and the times taken by them
> > accumulate, which may increase the total system suspend time quite
> > a bit.
> >
> > For this reason, move the resume of runtime-suspended devices up
> > to the next phase of device suspend (during system suspend), except
> > for the ones that have power.ignore_children set.  The exception is
> > made, because the devices with power.ignore_children set may still
> > be necessary for their children to be successfully suspended (during
> > system suspend) and they won't be resumed automatically as a result
> > of the runtime resume of their children.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> You can merge these two via your tree if you want.  I don't have any
> changes queued up for pci-driver.c.

I will, thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/