linux-kernel - Re: [PATCH 03/11] vfs: Don't allow overwriting mounts in the current mount namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ios4gjq1.fsf@xmission.com>
Date:	Mon, 24 Feb 2014 15:43:34 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Miklos Szeredi <miklos@...redi.hu>,
	Al Viro <viro@...iv.linux.org.uk>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Rob Landley <rob@...dley.net>,
	Christoph Hellwig <hch@...radead.org>,
	Karel Zak <kzak@...hat.com>,
	"J. Bruce Fields" <bfields@...ldses.org>
Subject: Re: [PATCH 03/11] vfs: Don't allow overwriting mounts in the current mount namespace

Stephen Rothwell <sfr@...b.auug.org.au> writes:

> On Tue, 18 Feb 2014 14:20:29 -0800 Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>>
>> For this kind of function return value it actually tends to work very
>> well, and in fact often generates slightly better code than "int". So
>> I don't _hate_ bool, and we've certainly had a lot more use creep in
>> lately, but I also don't really see "bool" as much of an upside.
>
> And in function declarations, it makes it very obvious that the function
> is not one of our "return 0 or -ERROR" ones.

So I played with this instance in particular.  The only difference winds
up being by the bool version uses byte instructions on %al and %bl
instead of their 32 bit interger equivalents on %eax and %ebx.

I also benchmarked the difference and on the most sensitive test I could
find.  will-it-scale/unlink2 (aka create,close,unlink each process in a
separate directory).  There were no measurable performance differences.

So for purposes of better documentation I have changed the function, and
I will repost my patches shortly.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/