linux-kernel - Re: [PATCH V8 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <10341096.99771393305930937.JavaMail.weblogic@epml25>
Date:	Tue, 25 Feb 2014 05:25:31 +0000 (GMT)
From:	Jingoo Han <jg1.han@...sung.com>
To:	kishon@...com, yuvaraj.cd@...sung.com
Cc:	kgene.kim@...sung.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, grant.likely@...aro.org,
	robh+dt@...nel.org, swarren@...dotorg.org, mark.rutland@....com,
	yuvaraj.cd@...il.com, ks.giri@...sung.com, vasanth.a@...sung.com,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH V8 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

On Mon, 24 Feb 2014 19:26:44, Kishon Vijay Abraham I wrote: 
> On Monday 24 February 2014 07:02 PM, Yuvaraj Kumar C D wrote:
> > This patch adds the SATA PHY driver for Exynos5250.Exynos5250 SATA
> > PHY comprises of CMU and TRSV blocks which are of I2C register Map.
> > So this patch also adds a i2c client driver, which is used configure
> 
> We no longer have i2c client driver here.

Right.

> > the CMU and TRSV block of exynos5250 SATA PHY.
> > 
> > This patch incorporates the generic PHY framework to deal with SATA
> > PHY.
> 
> It should be rephrased to have *uses* generic PHY framework. However I feel we
> can do away with this line.

Right, "incorporates" is confusing.

> > 
> > This patch depends on the below patch for the sata functionality
> > 	[1].ata: ahci_platform: Manage SATA PHY
> > 		by Roger Quadros <rogerq@...xxx>
> 
> hasn't this patch merged yet?

Currently, this patch was queued into libata tree, for-next. [1]

[1] http://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-next&id=21b5faeec229d4f70a7f60a7b0b065c98198f491

Best regards,
Jingoo Han