linux-kernel - RE: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Feb 2014 09:15:18 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Keith Packard' <keithp@...thp.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to
 ax88179 driver

From: Keith Packard
> The Lenovo OneLink dock includes a USB ethernet adapter using the
> AX88179 chip, but with a different USB ID. Add this new USB id to the
> driver so that it will autodetect the adapter correctly.
> 
> Signed-off-by: Keith Packard <keithp@...thp.com>
> Tested-by: Carl Worth <cworth@...rth.org>
> ---
>  drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index 8e8d0fc..dcf974f 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1418,6 +1418,19 @@ static const struct driver_info samsung_info = {
>  	.tx_fixup = ax88179_tx_fixup,
>  };
> 
> +static const struct driver_info lenovo_info = {
> +	.description = "ThinkPad OneLink Dock USB GigaLAN",
> +	.bind = ax88179_bind,
> +	.unbind = ax88179_unbind,
> +	.status = ax88179_status,
> +	.link_reset = ax88179_link_reset,
> +	.reset = ax88179_reset,
> +	.stop = ax88179_stop,
> +	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
> +	.rx_fixup = ax88179_rx_fixup,
> +	.tx_fixup = ax88179_tx_fixup,
> +};
> +
>  static const struct usb_device_id products[] = {
>  {
>  	/* ASIX AX88179 10/100/1000 */
> @@ -1435,6 +1448,10 @@ static const struct usb_device_id products[] = {
>  	/* Samsung USB Ethernet Adapter */
>  	USB_DEVICE(0x04e8, 0xa100),
>  	.driver_info = (unsigned long)&samsung_info,
> +}, {
> +	/* Lenovo ThinkPad OneLink GigaLAN */
> +	USB_DEVICE(0x17ef, 0x304b),
> +	.driver_info = (unsigned long)&samsung_info,
                                     ^^^^^^^^^^^^
I think you meant lenovo_info.

Actually it looks like the initialiser should be factored somehow
to that the list of functions and flags doesn't need repeating for
every clone.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/