| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140225005154.GA22937@kroah.com> Date: Mon, 24 Feb 2014 16:51:54 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Alexey Khoroshilov <khoroshilov@...ras.ru> Cc: Todza Louina <lidza.louina@...il.com>, devel@...verdev.osuosl.org, ldv-project@...uxtesting.org, driverdev-devel@...uxdriverproject.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] staging: dgap: remove unneeded status variables On Mon, Feb 24, 2014 at 12:21:51AM +0400, Alexey Khoroshilov wrote: > dgap_driver_start and dgap_Major_Control_Registered are used > to keep status of initialization of the driver as a whole and its "Major Control". > But the code that checks them is executed once on module init/unload. > That makes no sense in these variables as far as their values are predictable > at any time. > > Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> > --- > drivers/staging/dgap/dgap_driver.c | 105 ++++++++++++++++--------------------- > 1 file changed, 46 insertions(+), 59 deletions(-) This file is no longer in my tree, as the driver has been merged to one file. Can you please redo it against my latest staging-next branch of my staging.git tree and resend the series so that I can apply them? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists