| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHb8M2AigGWHvA4enc=JKbhvts6G-JT-9E0SPcvyeTWBZRnfKg@mail.gmail.com> Date: Tue, 25 Feb 2014 10:00:48 +0900 From: DaeSeok Youn <daeseok.youn@...il.com> To: Greg KH <gregkh@...uxfoundation.org> Cc: devel <devel@...verdev.osuosl.org>, paul.gortmaker@...driver.com, Dan Carpenter <dan.carpenter@...cle.com>, linux-kernel <linux-kernel@...r.kernel.org>, Elena Ufimtseva <ufimtseva@...il.com> Subject: Re: [PATCH v2] staging: ced401: fix double unlock bug Ok. I will make a patch based on linux-next branch and send it again. Thanks. Daeseok Youn 2014-02-25 9:43 GMT+09:00 Greg KH <gregkh@...uxfoundation.org>: > On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: >> >> After spin_lock() is called, all of if-else conditions in this brace >> should reach the end of else and spin_unlock() must be called. >> So It doesn't need to call spin_unlock() without a return statement >> for handling an error. >> >> Also sparse says: >> drivers/staging/ced1401/usb1401.c:1080:28: warning: >> context imbalance in 'Handle1401Esc' - unexpected unlock >> >> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com> > > This patch doesn't apply to my tree, can you please redo it against > linux-next and resend it so that I can apply it? > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists