linux-kernel - Re: [PATCH] pcie: Add Xilinx PCIe Host Bridge IP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Feb 2014 17:57:37 +0530
From:	Srikanth Thokala <sthokal@...inx.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	Srikanth Thokala <sthokal@...inx.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Michal Simek <michal.simek@...inx.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	linux-arm <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] pcie: Add Xilinx PCIe Host Bridge IP driver

Hi Jason,

On Fri, Feb 21, 2014 at 9:58 PM, Jason Gunthorpe
<jgunthorpe@...idianresearch.com> wrote:
> On Fri, Feb 21, 2014 at 08:18:00PM +0530, Srikanth Thokala wrote:
>
>> 00:00.0 Class 0604: Device 10ee:7081
>
> So this is great, a root port bridge is exactly correct - I would
> recommend using device 1 for this (device 0 is the host bridge in most
> cases), but I don't think that has any functional impact.
>
>>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
>> ParErr+ Stepping- SERR+ FastB2B- DisINTx-
>>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
>> <TAbort- <MAbort- >SERR- <PERR- INTx-
>>         Latency: 0, Cache Line Size: 64 bytes
>>         Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
>>         I/O behind bridge: 00000000-00000fff
>>         Memory behind bridge: 00000000-000fffff
>>         Prefetchable memory behind bridge: 00000000-000fffff
>
> What is going on here?  These ranges should match the MMIO aperture and
> critically must enclose the downstream bars:
>
>> 01:00.0 Class 0200: Device 14e4:1677 (rev 11)
>>         Region 0: Memory at 60000000 (64-bit, non-prefetchable) [size=64K]
>>         Expansion ROM at 60010000 [disabled] [size=64K]
>
> So one of those two is not right..

Sorry for the delay in response.  Thanks for pointing this.
I have series of conversations with my IP team and it is giving back
zero's when Type1 Header
Memory Base offset is read even the pcie stack writes the valid
addresses.  HW team is working on
this and they will take their own time to give a fix.  As there is no
functional impact, I believe there
is no issue with driver and should work on mainlining the driver.
Please suggest me on how to
proceed and accordingly I will send a v2 patch fixing the DT comments
pointed by you and Bjorn.

Thanks
Srikanth

>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/