lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 25 Feb 2014 06:36:38 -0800
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	Monam Agarwal <monamagarwal123@...il.com>,
	Ian Abbott <ian.abbott@....co.uk>,
	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters

On Tue, Feb 25, 2014 at 09:46:19AM +0000, Ian Abbott wrote:
> On 2014-02-24 16:49, Monam Agarwal wrote:
> > Signed-off-by: Monam Agarwal <monamagarwal123@...il.com>
> > ---
> >   drivers/staging/comedi/comedi_fops.c |    3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> > index ac1edd9..7da8566 100644
> > --- a/drivers/staging/comedi/comedi_fops.c
> > +++ b/drivers/staging/comedi/comedi_fops.c
> > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
> >   	async->cmd.data = NULL;
> >   	/* load channel/gain list */
> >   	async->cmd.chanlist = memdup_user(user_chanlist,
> > -					  async->cmd.chanlist_len * sizeof(int));
> > +					  async->cmd.chanlist_len
> > +					  * sizeof(int));
> 
> The `*` operator should go at the end of the line according to the 
> CodingStyle.

Which is why I modified it by hand before applying it :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ