linux-kernel - Re: [PATCH] i8042: Don't print an error message just because there's no chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA6zHH_rj_2cawnWxQ_JRiyybFsNM3d30cCN=FpMiMuXxg@mail.gmail.com>
Date:	Tue, 25 Feb 2014 11:06:41 -0500
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Adam Jackson <ajax@...hat.com>
Cc:	linux-input@...r.kernel.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Peter Jones <pjones@...hat.com>
Subject: Re: [PATCH] i8042: Don't print an error message just because there's
 no chip

On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@...hat.com> wrote:
> From: Peter Jones <pjones@...hat.com>
>
> Some systems, such as EFI-based Apple systems, won't necessarily have an
> i8042 to initialize. We shouldn't be printing an error message in this
> case, since not detecting the chip is the correct behavior.
>
> v2: Downgrade to pr_notice instead of pr_err.
>
> Signed-off-by: Adam Jackson <ajax@...hat.com>

Reviewed-by:  Josh Boyer <jwboyer@...oraproject.org>

> ---
>  drivers/input/serio/i8042.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index 020053f..05c6285 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void)
>  static int i8042_controller_check(void)
>  {
>         if (i8042_flush()) {
> -               pr_err("No controller found\n");
> +               pr_notice("No controller found\n");
>                 return -ENODEV;
>         }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/