linux-kernel - Re: [PATCH 1/8] security: Use a more current logging style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393356852.8716.33.camel@joe-AO722>
Date:	Tue, 25 Feb 2014 11:34:12 -0800
From:	Joe Perches <joe@...ches.com>
To:	Serge Hallyn <serge.hallyn@...ntu.com>
Cc:	linux-kernel@...r.kernel.org,
	Serge Hallyn <serge.hallyn@...onical.com>,
	James Morris <james.l.morris@...cle.com>,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH 1/8] security: Use a more current logging style

On Tue, 2014-02-25 at 13:10 -0600, Serge Hallyn wrote:
> Quoting Joe Perches (joe@...ches.com):
> > Convert printks to pr_<level>.
[]
> Acked-by: Serge E. Hallyn <serge.hallyn@...ntu.com>
> 
> Though should warn_setuid_and_fcaps_mixed be using
> pr_info_once()?

Yup, thanks.  I'll send a follow-on with your reported-by
if/after this is applied and I'll send a V2 now so James
could apply that instead if that's what he prefers.

> > diff --git a/security/commoncap.c b/security/commoncap.c
[]
> > @@ -46,9 +48,8 @@ static void warn_setuid_and_fcaps_mixed(const char *fname)
> >  {
> >  	static int warned;
> >  	if (!warned) {
> > -		printk(KERN_INFO "warning: `%s' has both setuid-root and"
> > -			" effective capabilities. Therefore not raising all"
> > -			" capabilities.\n", fname);
> > +		pr_info("warning: `%s' has both setuid-root and effective capabilities, therefore not raising all capabilities\n",
> > +			fname);

	pr_info_once(etc...

> >  		warned = 1;
> >  	}
> >  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/