lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Feb 2014 12:37:57 -0800 From: "H. Peter Anvin" <hpa@...or.com> To: Daniel Borkmann <dborkman@...hat.com> CC: Jan Beulich <JBeulich@...e.com>, mingo@...e.hu, tglx@...utronix.de, davem@...emloft.net, ffusco@...hat.com, tgraf@...hat.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] x86/hash: swap parameters of crc32_u32() On 02/25/2014 12:34 PM, Daniel Borkmann wrote: > On 02/25/2014 09:26 PM, H. Peter Anvin wrote: >> On 02/21/2014 02:33 AM, Jan Beulich wrote: >>> ... to match its two callers (i.e. the alternative would have been to >>> swap the arguments at the call sites). >>> >>> Signed-off-by: Jan Beulich <jbeulich@...e.com> >>> Cc: Francesco Fusco <ffusco@...hat.com> >>> Cc: Daniel Borkmann <dborkman@...hat.com> >>> Cc: Thomas Graf <tgraf@...hat.com> >>> Cc: David S. Miller <davem@...emloft.net> >>> --- >>> arch/x86/lib/hash.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Jan, do you want to do an updated version of this patch? Daniel, I >> presume you are going to push this patch? > > Good point. I'm fine if this is going to be picked up > by x86 maintainers. Feel free to add my ... > > Acked-by: Daniel Borkmann <dborkman@...hat.com> > > ... if you want to do an updated version that also > includes our recent findings/discussion, Jan. > Well, I don't want to change the names of the arguments in the inline function unless we also change the their functions and actually reverse the order of the operands as used. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists