lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Feb 2014 14:54:06 -0600 From: Alex Thorlton <athorlton@....com> To: linux-kernel@...r.kernel.org Cc: Alex Thorlton <athorlton@....com>, Gerald Schaefer <gerald.schaefer@...ibm.com>, Martin Schwidefsky <schwidefsky@...ibm.com>, Heiko Carstens <heiko.carstens@...ibm.com>, Christian Borntraeger <borntraeger@...ibm.com>, Andrew Morton <akpm@...ux-foundation.org>, Paolo Bonzini <pbonzini@...hat.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>, Ingo Molnar <mingo@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Andrea Arcangeli <aarcange@...hat.com>, Oleg Nesterov <oleg@...hat.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Alexander Viro <viro@...iv.linux.org.uk>, linux390@...ibm.com, linux-s390@...r.kernel.org, linux-mm@...ck.org, linux-api@...r.kernel.org Subject: [PATCH 3/3] exec: kill the unnecessary mm->def_flags setting in load_elf_binary() load_elf_binary() sets current->mm->def_flags = def_flags and def_flags is always zero. Not only this looks strange, this is unnecessary because mm_init() has already set ->def_flags = 0. Signed-off-by: Alex Thorlton <athorlton@....com> Suggested-by: Oleg Nesterov <oleg@...hat.com> Cc: Gerald Schaefer <gerald.schaefer@...ibm.com> Cc: Martin Schwidefsky <schwidefsky@...ibm.com> Cc: Heiko Carstens <heiko.carstens@...ibm.com> Cc: Christian Borntraeger <borntraeger@...ibm.com> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Paolo Bonzini <pbonzini@...hat.com> Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> Cc: Mel Gorman <mgorman@...e.de> Cc: Rik van Riel <riel@...hat.com> Cc: Ingo Molnar <mingo@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Andrea Arcangeli <aarcange@...hat.com> Cc: Oleg Nesterov <oleg@...hat.com> Cc: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Alexander Viro <viro@...iv.linux.org.uk> Cc: linux390@...ibm.com Cc: linux-s390@...r.kernel.org Cc: linux-kernel@...r.kernel.org Cc: linux-mm@...ck.org Cc: linux-api@...r.kernel.org --- fs/binfmt_elf.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 67be295..d09bd9c 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -579,7 +579,6 @@ static int load_elf_binary(struct linux_binprm *bprm) unsigned long start_code, end_code, start_data, end_data; unsigned long reloc_func_desc __maybe_unused = 0; int executable_stack = EXSTACK_DEFAULT; - unsigned long def_flags = 0; struct pt_regs *regs = current_pt_regs(); struct { struct elfhdr elf_ex; @@ -719,9 +718,6 @@ static int load_elf_binary(struct linux_binprm *bprm) if (retval) goto out_free_dentry; - /* OK, This is the point of no return */ - current->mm->def_flags = def_flags; - /* Do this immediately, since STACK_TOP as used in setup_arg_pages may depend on the personality. */ SET_PERSONALITY(loc->elf_ex); -- 1.7.12.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists