linux-kernel - Re: [PATCH 1/2] bdi: Fix hung task on sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140225224330.GB8568@mtj.dyndns.org>
Date:	Tue, 25 Feb 2014 17:43:30 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jens Axboe <axboe@...nel.dk>,
	Derek Basehore <dbasehore@...omium.org>, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] bdi: Fix hung task on sync

On Tue, Feb 25, 2014 at 11:29:13PM +0100, Jan Kara wrote:
> From: Derek Basehore <dbasehore@...omium.org>
> 
> bdi_wakeup_thread_delayed() used the mod_delayed_work() function to
> schedule work to writeback dirty inodes. The problem with this is that
> it can delay work that is scheduled for immediate execution, such as the
> work from sync_inodes_sb().  This can happen since mod_delayed_work()
> can now steal work from a work_queue.  This fixes the problem by using
> queue_delayed_work() instead. This is a regression caused by
> 839a8e8660b6 "writeback: replace custom worker pool implementation with
> unbound workqueue".
> 
> The reason that this causes a problem is that laptop-mode will change
> the delay, dirty_writeback_centisecs, to 60000 (10 minutes) by default.
> In the case that bdi_wakeup_thread_delayed() races with
> sync_inodes_sb(), sync will be stopped for 10 minutes and trigger a hung
> task. Even if dirty_writeback_centisecs is not long enough to cause a
> hung task, we still don't want to delay sync for that long.
> 
> We fix the problem by using queue_delayed_work() when we want to
> schedule writeback sometime in future. This function doesn't change the
> timer if it is already armed.
> 
> For the same reason, we also change bdi_writeback_workfn() to
> immediately queue the work again in the case that the work_list is not
> empty. The same problem can happen if the sync work is run on the rescue
> worker.
> 
> Fixes: 839a8e8660b6777e7fe4e80af1a048aebe2b5977
> CC: stable@...r.kernel.org
> Signed-off-by: Derek Basehore <dbasehore@...omium.org>
> Signed-off-by: Jan Kara <jack@...e.cz>

Reviewed-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/