linux-kernel - Re: [PATCH] net: kdoc struct net_device flags and priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB=NE6VQUpjXkDYjjc1bLeC+3X9cPpP83Kg6O3P=Yju=JaYAZw@mail.gmail.com>
Date:	Tue, 25 Feb 2014 15:08:08 -0800
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Ben Hutchings <ben@...adent.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: kdoc struct net_device flags and priv_flags

On Tue, Feb 25, 2014 at 2:39 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> 2014-02-25 14:19 GMT-08:00 Luis R. Rodriguez <mcgrof@...not-panic.com>:
>> On Mon, Feb 24, 2014 at 9:37 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
>>> Le lundi 24 février 2014, 23:53:43 David Miller a écrit :
>>>> They are visible to userspace via sysfs.
>>>
>>> In /sys/class/net/*/flags, although we are lacking quite a lot of documentation
>>> for the exported attributes there.
>>
>> I only see dev->flags there, I don't see any toggle capability for
>> priv_flags. Let me know if you find anywhere that userspace lets a
>> user toggle private flags, I just don't see it.
>
> You are right, those are dev->flags, not priv_flags, sorry about that.

No worries, if I don't hear back from anyone about how this is exposed
to userspace I'll toss a 2nd patch to the series that moves the
priv_flags out of UAPI as Ben suggested as a second step. Ben's point
about it being an unstable interface if userspace would rely on them
is also pretty important, so not sure why we'd let anyone on userspace
rely on them. I'll obviously test compile this before submitting
though.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/