linux-kernel - Re: [PATCH v2 0/6] spi: sh-msiof: Add support for R-Car H2 and M2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Feb 2014 17:13:18 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Mark Brown <broonie@...nel.org>,
	Takashi Yoshii <takasi-y@....dti.ne.jp>,
	linux-spi@...r.kernel.org, SH-Linux <linux-sh@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/6] spi: sh-msiof: Add support for R-Car H2 and M2

On Tue, Feb 25, 2014 at 7:21 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>         Hi Mark,
>
> This patch series refactors the sh-msiof SPI driver and adds support for
> the MSIOF variant in the Renesas R-Car H2 (r8a7790) and M2 (r8a7791) SoCs.
>
> It was tested on the Lager and Koelsch development boards, using a dummy
> driver for the Renesas r2a11302ft PMIC that reads out the PMIC's version ID.
>
>     [1/6] spi: sh-msiof: Improve bindings
>     [2/6] spi: sh-msiof: Move default FIFO sizes to device ID data
>     [3/6] spi: sh-msiof: Add support for R-Car H2 and M2
>     [4/6] spi: sh-msiof: Move clock management to (un)prepare_message()
>     [5/6] spi: sh-msiof: Convert to let spi core validate xfer->bits_per_word
>     [6/6] spi: sh-msiof: Use core message handling instead of spi-bitbang
>
> These are (reworked versions of) the remaining patches not taken from v1.
> Changelogs are available in the individual patches.
>
> Some of this work was based on a patch series by Takashi Yoshii
> <takasi-y@....dti.ne.jp>.

Hi Geert,

Thanks for this updated version. I like the way you reworked the DT
bindings to let the FIFO configuration stay in the driver. Also
getting rid of the now-not-needed bitbang dependency is a great thing.
All these patches look good to me.

Acked-by: Magnus Damm <damm@...nsource.se>

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/